On Mon Aug 1 09:06:07 2022 +0000, Bernhard K��lbl wrote:
Oh, and the prefix for any commit is usually the folder where you do commit to. So instead of `cabinet.dll: Do foobar.` it's just `cabinet: Do foobar.` One exception are headers, where it's `include/foo.h: Do foobar.`
So, I renamed this pr and my commits to follow the (hopefully now) correct name scheme and split the commit into smaller ones, one adding the test itself and expecting it to fail, one with the implementation of DllGetVersion and related changes + not failing test and one with DllGetVersion + not failing test anymore. Is this the recommended way? Can I improve my pr/commits in any other way?
Thank you very much! :)