Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
- const struct hlsl_type *sampler_type;
- struct hlsl_ir_resource_load *load;
- struct hlsl_ir_load *sampler_load;
- struct hlsl_ir_node *coords;
- if (params->args_count != 2 && params->args_count != 4)
- {
hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_WRONG_PARAMETER_COUNT,
"Wrong number of arguments to function '%s': expected 2 or 4, but got %u.", name, params->args_count);
return false;
- }
- if (params->args_count == 4)
- {
hlsl_fixme(ctx, loc, "Samples with gradients are not implemented.\n");
return false;
We don't really need to abort here either.