On Sat Jun 8 23:15:39 2024 +0000, Elizabeth Figura wrote:
Commit 1/3 isn't precisely necessary; we could simply forward to the corresponding (or lowest) version of d3dcompiler. On the other hand it would be necessary if we wanted to, as native does, automatically promote ps 1.x to 2.0, while still allowing versions 31 and lower to compile them.
If we ever want to do that, we should consider using PARENTSRC instead of duplicating the whole thing, in principle at least. Right now that's already reserved for d3dx9_xx -> d3dx9_36, although the only reason for that is to avoid forwarded exports (bug 21817) which can now be alternatively solved via -import in the .spec file.
So I guess I'd prefer forwarding to d3dcompiler for the time being, assuming that works properly, and reevaluating once we actually need a separate implementation for d3dx9 (whether it's really separate or mostly shared via PARENTSRC). That said, I'm not really opposed to 1/3.