Re: [PATCH v7 0/6] MR8890: windows.devices.enumeration: Add support for parsing AQS filter strings.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/aqs.c:
> - return S_OK;
>
> +}
> -
>
> +HRESULT get_compare_expr( struct aqs_parser *parser, enum operator_compare op, const WCHAR *prop_name,
> -
>                      const PROPVARIANT *val, struct aqs_expr **ret_expr )
>
> +{
> - struct aqs_expr *expr;
> - HRESULT hr;
> -
> - if (!(expr = calloc( 1, sizeof( *expr )))) return (parser->error = E_OUTOFMEMORY);
> - if (FAILED(hr = IPropertySystem_GetPropertyDescriptionByName( parser->propsys, prop_name, &IID_IPropertyDescription, (void **)&expr->u.compare.prop_desc)))
> - {
> -
>    free( expr );
> -
>    parser->error = hr == TYPE_E_ELEMENTNOTFOUND ? E_INVALIDARG : hr;
> -
>    return parser->error;
> - }

The `compare.prop_desc` member doesn't seem to be used, do you even need to keep it around?