Re: [PATCH v2 0/19] MR7516: Server-side thread priorities implementation (Part 3)

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/ntdll/unix/thread.c:
> -
>    }
> -
>    SERVER_END_REQ;
> -
>    if (status == STATUS_SUCCESS)
> -
>    {
> -
>        SERVER_START_REQ( get_thread_priority_info )
> -
>        {
> -
>            req->handle = wine_server_obj_handle( handle );
> -
>            if (!(status = wine_server_call( req )))
> -
>            {
>                info.Priority           = reply->priority;
> -
>            info.BasePriority           = reply->priority;  /* FIXME */
> -
>                info.BasePriority       = reply->base_priority;
>            }
>        }
>        SERVER_END_REQ;
> -
>    }

This makes two requests instead of one, I don't think this is good. You should find a way to squeeze the information in, increase the fixed request size, or use varargs if the data doesn't fit in the fixed request part.