Re: [PATCH v4 0/12] MR672: vkd3d-shader/ir: Introduce a better CFG structurizer, part 3.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
> -
>        in_degrees[i] = UINT_MAX;
> -
>        continue;
> -
>    }
> -
> -
>    in_degrees[i] = block->predecessors.count;
> -
> -
>    /* Do not count back edges. */
> -
>    if (cfg->loops_by_header[i])
> -
>    {
> -
>        assert(in_degrees[i] > 0);
> -
>        in_degrees[i] -= 1;
> -
>    }
> -
> -
>    if (in_degrees[i] == 0 && block != cfg->entry)
> -
>    {
> -
>        ERR("Unexpected entry point %u.\n", block->label);

Is this more accurately a `FIXME`? We don't normally emit `ERR` because a shader is invalid. Ditto for the entry point check after the loop.