Re: [PATCH v2 0/2] MR5020: Draft: kernelbase/file: implement CopyFile2

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/kernelbase/file.c:
> - if (ret) SetLastError( 0 );
> return ret;
>
> }
>
> +/***********************************************************************
> -
> - CopyFileExW   (kernelbase.@)
> - */
>
> +BOOL WINAPI CopyFileExW( const WCHAR *source, const WCHAR *dest, LPPROGRESS_ROUTINE progress,
> -
>                     void *param, BOOL *cancel_ptr, DWORD flags )
>
> +{
> - HRESULT ret;
> - COPYFILE2_EXTENDED_PARAMETERS params;
> -
> - params.dwSize = sizeof(params);
> - params.dwCopyFlags = flags;

Maybe FIXME progress/cancel here too if nonnull? (Ideally they'd be placed in the params, but PCOPYFILE2_PROGRESS_ROUTINE is quite different from LPPROGRESS_ROUTINE, and writing a converter wrapper that CopyFile2 never calls would be difficult to test, so better not.)