[PATCH v2 1/2] kernel32: Test ReplaceFileW with forward slashes.

[Roman Pišl]

From: Roman Pišl

---
 dlls/kernel32/tests/file.c | 66 ++++++++++++++++++++++++++++----------
 1 file changed, 49 insertions(+), 17 deletions(-)

diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c
index 68b9f53700e..eceb023ea46 100644
--- a/dlls/kernel32/tests/file.c
+++ b/dlls/kernel32/tests/file.c
@@ -4119,28 +4119,13 @@ static void test_ReplaceFileA(void)
  * ReplaceFileW is a simpler case of ReplaceFileA, there is no
  * need to be as thorough.
  */
-static void test_ReplaceFileW(void)
+static void test_ReplaceFileW_(const WCHAR *temp_path)
 {
     WCHAR replaced[MAX_PATH], replacement[MAX_PATH], backup[MAX_PATH];
     static const WCHAR prefix[] = {'p','f','x',0};
-    WCHAR temp_path[MAX_PATH];
     DWORD ret;
     BOOL removeBackup = FALSE;
-
-    if (!pReplaceFileW)
-    {
-        win_skip("ReplaceFileW() is missing\n");
-        return;
-    }
-
-    ret = GetTempPathW(MAX_PATH, temp_path);
-    if (ret == 0 && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED)
-    {
-        win_skip("GetTempPathW is not available\n");
-        return;
-    }
-    ok(ret != 0, "GetTempPathW error %ld\n", GetLastError());
-    ok(ret < MAX_PATH, "temp path should fit into MAX_PATH\n");
+    HANDLE hnd;

ret = GetTempFileNameW(temp_path, prefix, 0, replaced);
     ok(ret != 0, "GetTempFileNameW error (replaced) %ld\n", GetLastError());
@@ -4189,6 +4174,16 @@ static void test_ReplaceFileW(void)
     ret = pReplaceFileW(replaced, replacement, backup, 0, 0, 0);
     ok(!ret, "ReplaceFileW: error %ld\n", GetLastError());

+    /* open file in exclusive mode */
+    hnd = CreateFileW(replaced, GENERIC_READ | GENERIC_WRITE, FILE_SHARE_DELETE, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
+    ok(hnd != INVALID_HANDLE_VALUE, "CreateFile unexpected error %ld\n", GetLastError());
+    ret = GetTempFileNameW(temp_path, prefix, 0, replacement);
+    ok(ret != 0, "GetTempFileNameW error (replacement) %ld\n", GetLastError());
+    ret = pReplaceFileW(replaced, replacement, NULL, 0, 0, 0);
+    ok(ret || GetLastError() == ERROR_ACCESS_DENIED,
+       "ReplaceFileW: error %ld\n", GetLastError());
+    CloseHandle(hnd);
+
     ret = pReplaceFileW(replaced, replacement, NULL, 0, 0, 0);
     ok(!ret && (GetLastError() == ERROR_FILE_NOT_FOUND ||
        GetLastError() == ERROR_ACCESS_DENIED),
@@ -4204,6 +4199,43 @@ static void test_ReplaceFileW(void)
     }
 }

+static void test_ReplaceFileW(void)
+{
+    static const WCHAR *tmp_on_z = L"Z:/tmp";
+    WCHAR temp_path[MAX_PATH];
+    const WCHAR *tmp_path_fwslash;
+    DWORD attrib, ret;
+
+    if (!pReplaceFileW)
+    {
+        win_skip("ReplaceFileW() is missing\n");
+        return;
+    }
+
+    ret = GetTempPathW(MAX_PATH, temp_path);
+    if (ret == 0 && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED)
+    {
+        win_skip("GetTempPathW is not available\n");
+        return;
+    }
+    ok(ret != 0, "GetTempPathW error %ld\n", GetLastError());
+    ok(ret < MAX_PATH, "temp path should fit into MAX_PATH\n");
+
+    test_ReplaceFileW_(temp_path);
+
+    attrib = GetFileAttributesW(tmp_on_z);
+    if (attrib != INVALID_FILE_ATTRIBUTES && (attrib & FILE_ATTRIBUTE_DIRECTORY))
+        tmp_path_fwslash = tmp_on_z;
+    else
+    {
+        for (int i = 0; i < wcslen(temp_path); i++)
+            if (temp_path[i] == L'\') temp_path[i] = L'/';
+        tmp_path_fwslash = temp_path;
+    }
+
+    test_ReplaceFileW_(tmp_path_fwslash);
+}
+
 static void test_CreateFile(void)
 {
     static const struct test_data