Re: [PATCH v11 0/2] MR1268: wininet: Partially implement InternetSetFilePointer

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/wininet/tests/http.c:
> -
> - /* NULL handle tests */
> - pos = InternetSetFilePointer(NULL, 0, NULL, FILE_BEGIN, 0);
> - err = pos == INVALID_SET_FILE_POINTER ? GetLastError() : NO_ERROR;
> - expected = pos == INVALID_SET_FILE_POINTER && err == ERROR_INVALID_HANDLE;
> - ok(expected, "Expected ERROR_INVALID_HANDLE. Got %lu\n", err);
> - pos = InternetSetFilePointer(NULL, 0, NULL, FILE_CURRENT, 0);
> - err = pos == INVALID_SET_FILE_POINTER ? GetLastError() : NO_ERROR;
> - expected = pos == INVALID_SET_FILE_POINTER && err == ERROR_INVALID_HANDLE;
> - ok(expected, "Expected ERROR_INVALID_HANDLE. Got %lu\n", err);
> - pos = InternetSetFilePointer(NULL, 0, NULL, FILE_END, 0);
> - err = pos == INVALID_SET_FILE_POINTER ? GetLastError() : NO_ERROR;
> - expected = pos == INVALID_SET_FILE_POINTER && err == ERROR_INVALID_HANDLE;
> - ok(expected, "Expected ERROR_INVALID_HANDLE. Got %lu\n", err);
> -
> - /* INTERNET_FLAG_DONT_CACHE tests */

INTERNET_FLAG_DONT_CACHE will have no effect until request is actually sent. Those tests are interesting as well, but actual INTERNET_FLAG_DONT_CACHE tests would be still interesting.