On Tue Aug 27 17:30:52 2024 +0000, Rémi Bernon wrote:
I have no idea, I'm just keeping the current behavior but I don't know what this shell desktop is about and yes, starting explorer with /desktop= now usually starts a virtual desktop mode. Maybe it's been broken with the recent virtual desktop / systray changes. The only reference about it I can find is some wineandroid related feature. I'm not sure to understand what you mean with enabled by default? It's enabled by default in virtual desktop mode, which shouldn't maximize the windows over the taskbar or am I missing something?
Before commit 118810ad3bac91bfeea81e4408059d48c158e8c5, `./wine explorer /desktop=foobar notepad` opened Wine Notepad in a virtual desktop without a taskbar. If you wanted the taskbar, you had to either set `EnableShell` in the registry or set the name of the virtual desktop to "shell", for example `./wine explorer /desktop=shell notepad`. This feature has been documented for many years in the [Wine Wiki](https://gitlab.winehq.org/wine/wine/-/wikis/Commands/explorer). I did not notice until this evening that the behavior has changed; it seems that ever since the aforementioned commit, the taskbar is shown by default in all virtual desktops and not just the one named "shell".
As far as maximizing, if you click the Maximize button on Wine Notepad in a virtual desktop, Wine Notepad will fill the entire virtual desktop, covering the taskbar. That's very different from Windows, where no window can overlap over the taskbar. My argument was that we might not want to turn on Wine's taskbar by default if it behaves so differently from Windows. However, it doesn't really matter to me whether or not the taskbar is shown by default, and the default has already been changed.
Assuming that we are going to keep the new default, we should remove all references to the no-longer-special "shell" desktop. We could, however, go back to the old default and make "shell" special again. I do not have a strong preference.