Re: [PATCH v3 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/mbcs.c:
> -
> -
> _mbsnbcnt(MSVCRT.@)
> -
> -
> _mbsnbcnt_l(MSVCRT.@)
> - 'b' is for byte count.
> */
>
> -size_t CDECL _mbsnbcnt(const unsigned char* str, size_t len)
> +size_t CDECL _mbsnbcnt_l(const unsigned char* str, size_t len, _locale_t locale)
>  {
> - size_t ret;
> - if(get_mbcinfo()->ismbcodepage)
> - {
> - const unsigned char* xstr = str;
> - while(*xstr && len-- > 0)
> - size_t ret;
> - pthreadmbcinfo mbcinfo;
> -
> - if (!MSVCRT_CHECK_PMT(str && len > 0))

It doesn't work correctly in `len == 0` case.