Re: [PATCH v3 0/2] MR9094: rometadata: Add stub + tests for IMetaDataTables

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/rometadata/tests/rometadata.c:
> - ULONG exp_key_idx;
> - const char *exp_name;
>
> +};
> -
>
> +struct type_info
> +{
> - DWORD exp_flags;
> - const char *exp_name;
> - const char *exp_namespace;
>
> +};
> -
>
> +#define TableFromToken(tk) (TypeFromToken(tk) >> 24)
> -
>
> +static void test_MetaDataDispenser_OpenScope(void)
> +{
> - static const struct table_info tables[45] = {

It would be nice to use symbolic constants for the table indexes, so 0 becomes e.g. TABLE_MODULE, TableFromToken(mdtMemberRef) becomes TABLE_MEMBERREF and 45 would be TABLE_MAX.