Re: [PATCH 0/1] MR5741: Draft: server: Implement key auto-repeat.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about server/queue.c:
> -
> * remove the dependency on 'current' and pass all required information
> -
> * explicitly to queue_keyboard_message. */
> - if ((current = get_foreground_thread( desktop, desktop->key_repeat.win )))
> - {
> -
>    queue_keyboard_message( desktop, 0, &desktop->key_repeat.input, IMO_HARDWARE, NULL, 1 );
> -
>    current = NULL;
> - }
>
> +}
> -
>
> +static int is_vkey_repeatable( unsigned char vkey )
> +{
> - return vkey != VK_LSHIFT && vkey != VK_RSHIFT &&
> -
>       vkey != VK_LCONTROL && vkey != VK_RCONTROL &&
> -
>       vkey != VK_LMENU && vkey != VK_RMENU &&
> -
>       vkey != VK_LWIN && vkey != VK_RWIN;
>
> +}

Is manually excluding some vkeys necessary?