On Wed Nov 16 14:38:34 2022 +0000, Gabriel Ivăncescu wrote:
Not aware of one specifically, but the tests are nice to have, and I don't know how to test it without actually implementing it (and sending the events). Is bailing out on Wine (in the tests) with a skip or FIXME good enough? (like we have in some js tests) The reason for the tests is that this event gets registered by apps, and according to spec it should be sent during unload as well, not just minimize. However, native doesn't seem to do that, but without tests, I wouldn't have known this… hence why they're nice to have, IMO. Any ideas here how to keep the tests? BTW in private conversation, Conor also said in WinEvents could be used here, EVENT_SYSTEM_MINIMIZESTART and EVENT_SYSTEM_MINIMIZEEND, but they're not implemented in Wine so I can't right now, but that's probably the best way to implement it at some point.
I sent a version that keeps tests but has a check for native to have proper waits then (there's still todo_wine, so when it gets implemented, we'll know to remove that FIXME part as well). Now it's just a stub.
It's slightly ugly but IMO much better to have the tests in to prevent confusion whether these events are actually needed by apps or not. I know it would've helped me.