Re: [PATCH 2/4] vkd3d-shader: Introduce a compile option to use Unknown format for typed UAV loads.

[Zebediah Figura (she/her)]

On 8/1/22 08:31, Conor McCarthy wrote:
> diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h
> index ebddbba7..fc42fef4 100644
> --- a/include/vkd3d_shader.h
> +++ b/include/vkd3d_shader.h
> @@ -99,6 +99,22 @@ enum vkd3d_shader_compile_option_buffer_uav
>       VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_BUFFER_UAV),
>   };
>
> +/**
> -
> - Determines how typed UAVs are declared.
> - */
>
> +enum vkd3d_shader_compile_option_typed_uav
> +{
> - /** Use R32(u)i/R32f format for UAVs which are read from. This is the default value. */
> - VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32     = 0x00000000,
> - /**
> -
> * Use Unknown format for UAVs which are read from. This should only be set if
> -
> * shaderStorageImageReadWithoutFormat is enabled in the target environment.
> -
> */
> - VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN = 0x00000001,
> -
> - VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV),
>
> +};

Would it make sense for this to be part of enum 
vkd3d_shader_spirv_extension instead? It's technically not an extension, 
but inasmuch as extensions specify features I think it fits.