Francisco Casas (@fcasas) commented about libs/vkd3d-shader/hlsl.y:
- load_params.resource = object;
- load_params.level = args[ARG_MIP_LEVEL];
- load_params.format = hlsl_get_vector_type(ctx, uint_resinfo ? HLSL_TYPE_UINT : HLSL_TYPE_FLOAT, 4);
- if (!(res_info = hlsl_new_resource_load(ctx, &load_params, loc)))
return false;
- list_add_tail(instrs, &res_info->entry);
- if (!add_assignment_from_component(ctx, instrs, args[ARG_WIDTH], res_info, 0, loc))
return false;
- if (!add_assignment_from_component(ctx, instrs, args[ARG_HEIGHT], res_info, 1, loc))
return false;
- if (!add_assignment_from_component(ctx, instrs, args[ARG_ELEMENT_COUNT], res_info,
object_type->sampler_dim == HLSL_SAMPLER_DIM_3D ? 1 : 2, loc))
Shouldn't be ``` object_type->sampler_dim == HLSL_SAMPLER_DIM_3D ? 2 : 1 ``` ?