Re: [PATCH v2 0/5] MR5844: opengl32: Add default implementations for wglGetPixelFormatAttrib{i,f}vARB.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winex11.drv/opengl.c:
>  pf->pfd.iLayerType = PFD_MAIN_PLANE;
>
> - if (!has_swap_method) pf->swap_method = WGL_SWAP_EXCHANGE_ARB;
> - else if (!pglXGetFBConfigAttrib( gdi_display, fmt->fbconfig, GLX_SWAP_METHOD_OML, &value ))
> - {
> -
>    switch (value) {
> -
>    case GLX_SWAP_EXCHANGE_OML: pf->swap_method = WGL_SWAP_EXCHANGE_ARB; break;
> -
>    case GLX_SWAP_COPY_OML: pf->swap_method = WGL_SWAP_COPY_ARB; break;
> -
>    case GLX_SWAP_UNDEFINED_OML: pf->swap_method = WGL_SWAP_UNDEFINED_ARB; break;
> -
>    default: { ERR( "Unexpected swap method %x.\n", value ); pf->swap_method = 0; break; }
> -
>    }

```suggestion:-5+0
        switch (value)
        {
        case GLX_SWAP_EXCHANGE_OML: pf->swap_method = WGL_SWAP_EXCHANGE_ARB; break;
        case GLX_SWAP_COPY_OML: pf->swap_method = WGL_SWAP_COPY_ARB; break;
        case GLX_SWAP_UNDEFINED_OML: pf->swap_method = WGL_SWAP_UNDEFINED_ARB; break;
        default:
            ERR( "Unexpected swap method %x.\n", value );
            pf->swap_method = 0;
            break;
        }
```

Then, should this be `swap_method = -1` maybe? Or use `WGL_SWAP_EXCHANGE_ARB` as a default?