Jeffrey Smith (@whydoubt) commented about dlls/mmdevapi/devicetopology.c:
+static ULONG WINAPI connector_AddRef(IConnector *iface) +{
- struct connector *This = impl_from_IConnector(iface);
- ULONG ref = InterlockedIncrement(&This->ref);
- TRACE("(%p) new ref %lu\n", This, ref);
- return ref;
+}
+static ULONG WINAPI connector_Release(IConnector *iface) +{
- struct connector *This = impl_from_IConnector(iface);
- ULONG ref = InterlockedDecrement(&This->ref);
- TRACE("(%p) new ref %lu\n", This, ref);
- if (!ref)
HeapFree(GetProcessHeap(), 0, This);
The other files in mmdevapi have recently been changed to use CRT allocation functions (malloc, free, etc.), so you should follow suit here. ```suggestion:-0+0 free(This); ```