On Mon Apr 21 11:07:25 2025 +0000, Jinoh Kang wrote:
I think the intention of this MR is that, rather than fixing an app directly, it simplifies the work for !246 when dealing with casefold filesystems. The next step would be to explore how to simplify this MR so that only the ncessary groundwork for !246 renamins. The extra complexity could only be justified if there was an app with a possibility of renaming hardlink to the link itself. But maybe, fixing !246 the proper way might end up needing this MR, in which case that alone could be a strong argument for this patch. Again, my sincere apologies for backtracking from my original position. As someone who took up the reviewing work, I take responsibility for not thinking through what the Wine project's ultimate goal is when judging neccessity of a contribution (and thanks @julliard for pointing this out on IRC). I nonetheless appreciate your effort so far, including the multiple iterations that led to the latest revision of !246. It has been a great time working with you!
Understandable, and yes even if it's just to simplify !246 first, it's also a step in the right direction in terms of correctness (which IMO is the most important), and while no app "directly" requires this to not "break", it is indeed used by e.g. file managers (it was my original issue with !246 too, and still is, though I carry my own patches for it), and I've seen people interested in it so I'm not the only one that uses file managers in Wine...
So personally I'd rather have it fixed as-is, but if it would help to reduce its scope to get it in (as long as !246 can get in, since I need that one) I wouldn't be too hesitant to change. That said, I'd want to know for sure before I proceed since IMO we put quite some work into it so far to have it correct.
@julliard any thoughts please? Or would someone else review it?