On Thu Aug 31 08:28:27 2023 +0000, Matteo Bruni wrote:
AFAICS, most of those were "accidentally" passing with older vkd3d releases, but then vkd3d-shader started to properly return compilation failures on unsupported features so that now we don't pass these tests anymore. I think we want to restore todo_wines for those. I can write a patch for this, to be squashed into 3b2a47dec5747bbb3dd443fb3380efcd88686fa7, if you like. How do you prefer that I send it your way? I'll default to attaching it here if I don't hear anything :smile: I don't seem to reproduce the test failures at line 1180 locally. The test results suggest that there is some surprising inaccuracy in the sampled texture color on the test machines. The generated pixel shaders look correct though and are virtually identical to the native-generated ones, so I guess we should just raise the test tolerance (i.e. the shader does no math, I don't see how wined3d could mess any of this up, I'd blame the driver and move on...) For this one it would be raising the last argument to the compare_vec4() call on line 1180 to higher powers of 2 until the test passes.
Listing the new compilation errors for these shaders for reference: <pre> vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:3:26: E5017: Aborting due to not yet implemented feature: SM1 non-float expression. vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:3:1: E5017: Aborting due to not yet implemented feature: Instruction type HLSL_IR_IF. hlsl_d3d9.c:561: <anonymous>:3:26: E5017: Aborting due to not yet implemented feature: SM1 non-float expression.
vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:3:18: E5017: Aborting due to not yet implemented feature: SM1 non-float expression. vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:3:18: E5017: Aborting due to not yet implemented feature: Instruction type HLSL_IR_IF. hlsl_d3d9.c:585: <anonymous>:3:18: E5017: Aborting due to not yet implemented feature: SM1 non-float expression.
vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:5:21: E5017: Aborting due to not yet implemented feature: SM1 non-float expression. vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:5:19: E5017: Aborting due to not yet implemented feature: SM1 non-float expression. vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:5:19: E5017: Aborting due to not yet implemented feature: SM1 "cast" expression. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001.
vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:4:21: E5017: Aborting due to not yet implemented feature: SM1 "sin" expression. vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:5:21: E5017: Aborting due to not yet implemented feature: SM1 "cos" expression. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001.
vkd3d:0124:trace:vkd3d_shader_compile <anonymous>:1:9: E5017: Aborting due to not yet implemented feature: Generic samplers need to be lowered. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. </pre> The last one refers to the last two shaders in test_samplers() which use separate sampler and texture via the newer t.Sample() syntax.