Re: [PATCH v17 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ddraw/device.c:
> -
> - FIXME("primitive_type %#x not supported\n", primitive_type);
> - goto done;
> -
>
> +points:
> - for (int idx = 0; idx < vertex_count; idx ++) {
> -
>    device->ddraw_device_buffer.buffer_indices[device->ddraw_device_buffer.buffer_indice_count++] = device->ddraw_device_buffer.buffer_vertex_count++;
> - }
> -
> - goto done;
> -
>
> +fan:
> - if (vertex_count < 3) {
> -
> WARN("vertex_count %lu lower than 3. not buffering", vertex_count);
> -
> return WINED3DERR_NOTAVAILABLE;
> - }

"Vertex count %lu is lower than 3; not buffering.\n"

(We try to make messages grammatical in Direct3D, but more importantly, it's missing a final newline.)

Somewhat relatedly, should we apply a maximum limit? We don't want to waste time rewriting vertices if the application is well-behaved.