Re: [PATCH v2 0/5] MR8129: widl: Write the table stream.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about tools/widl/metadata.c:
> }
>
> +static void serialize_table_idx( UINT idx, enum table target )
> +{
> - UINT size = tables[target].count >> 16 ? sizeof(UINT) : sizeof(USHORT);
> - add_bytes( &tables_disk, (const BYTE *)&idx, size );
>
> +}
> -
>
> +static enum table typedef_or_ref_to_table( UINT token )
> +{
> - switch (token & 0x3)
> - {
> - case 0: return TABLE_TYPEDEF;
> - case 1: return TABLE_TYPEREF;
> - case 2: return TABLE_TYPESPEC;
> - default: exit( 1 );

Maybe an assert would be better so it doesn't exit silently.