On Tue Apr 4 14:18:19 2023 +0000, Alexandros Frantzis wrote:
I'll admit sometimes it's challenging to guess what's the right style and the most important consistency level/scope, since many files (including this one) contain a mix of styles, even a few lines apart. In this particular case, I went with macro call (no spaces, like all other TRACE calls in the file) vs function call (mostly spaces) split, causing an inter-line inconsistency (which I guess what your comment is mainly about?). I am happy to use any preferred style, I just wish it was easier to guess what that style is. So is the preferred way to use a with-spaces style for `TRACE()` (even though all other TRACE calls in the file use a no-space style)?
I think it's fine to assume it's either always spaces in paren for all calls, or never. There's some variations in some places I'm not even sure why.
In general trying to keep what was there is probably the best course, especially if the code was changed recentely. Then, try to keep consistent within a function, then within the file and then the module.
In `winex11` case it's a mixed bag, but I believe the module's maintainer prefers the style with more spacing, and I think the module already has a fair amount of this, so we should try to move towards more of it.