Re: [PATCH v3 0/6] MR9275: jscript: Semi-implement Typed Arrays.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/jscript/arraybuf.c:
> +static void TypedArray_destructor(jsdisp_t *dispex)
> +{
> - TypedArrayInstance *typedarr = typedarr_from_jsdisp(dispex);
> - if(typedarr->buffer)
> -
>    jsdisp_release(&typedarr->buffer->dispex);
>
> +}
> -
>
> +static HRESULT TypedArray_lookup_prop(jsdisp_t *dispex, const WCHAR *name, unsigned flags, struct property_info *desc)
> +{
> - TypedArrayInstance *typedarr = typedarr_from_jsdisp(dispex);
> -
> - /* Typed Arrays override every positive index */
> - return jsdisp_index_lookup(&typedarr->dispex, name, INT_MAX, desc);
>
> +}
> -
>
> +static inline HRESULT TypedArray_prop_get(unsigned desc_idx, jsdisp_t *dispex, unsigned idx, jsval_t *r)

I'd suggest passing the descriptor as a struct pointer (moving resolving `typed_array_descs` to the caller) where possible.