On Wed Sep 14 08:47:10 2022 +0000, Alexandre Julliard wrote:
It turns out that it breaks the ddraw tests, could you please have a look?
Oof, sorry... though it doesn't look like it's coming from this?
I reverted each commit and it still fails after the last one: * https://testbot.winehq.org/JobDetails.pl?Key=123226 * https://testbot.winehq.org/JobDetails.pl?Key=123227 * https://testbot.winehq.org/JobDetails.pl?Key=123228 * https://testbot.winehq.org/JobDetails.pl?Key=123229 * https://testbot.winehq.org/JobDetails.pl?Key=123230 * https://testbot.winehq.org/JobDetails.pl?Key=123231 * https://testbot.winehq.org/JobDetails.pl?Key=123232
I bisected the failure and it looks like it's caused instead by 44d6f2adbcca119faebc095f3cfbeeafc50d04f3, from https://gitlab.winehq.org/wine/wine/-/merge_requests/657. Reverting it alone fixes it:
https://testbot.winehq.org/JobDetails.pl?Key=123248 vs https://testbot.winehq.org/JobDetails.pl?Key=123249