Re: [PATCH v2 0/2] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/environ.c:
> -
>    char *second = (*p_environ)[1];
> -
>    char *new_first;
> -
>    char *equal;
> -
>    size_t len = strlen(first);
> -
> -
>    new_first = malloc( len + 1 + 1 );
> -
>    ok( new_first != NULL, "allocation failed\n" );
> -
>    strcpy( new_first, first );
> -
>    strcat( new_first, "A" );
> -
>    _putenv( new_first );
> -
> -
>    todo_wine
> -
>    ok( second == (*p_environ)[1], "_environ[1] shouldn't have changed\n" );
> -
>    ok( !strcmp( new_first, (*p_environ)[0] ), "_environ[0] shouldn't have changed\n" );
> -
>    todo_wine
> -
>    ok( !strcmp( second, (*p_environ)[1] ), "_environ[1] shouldn't have changed\n" );

If `second == (*p_environ)[1]` it doesn't make sense to compare the buffers.