On Thu Jan 5 20:14:36 2023 +0000, Gabriel Ivăncescu wrote:
Great work with this so far. I just have a question, is there a reason why you're duplicating the "common bitmaps" from comctl32? You could be using, for example, `HIST_BACK` and `HIST_FORWARD` from the `IDB_HIST_LARGE_COLOR`, and `VIEW_PARENTFOLDER` from the `IDB_VIEW_LARGE_COLOR`. They're supposed to be standard. `hhctrl.ocx` seems to be using them, maybe you can take a look there to see how it's done? Not sure about the refresh. It seems `hhctrl.ocx` is also duplicating it, so that may have to remain…
Originally, I was keeping around a toolbar for `comctl32` icons (setup required icons with `TB_ADDBITMAP` and then grab the image list with `TB_GETIMAGELIST`).
Which worked fine, until the refresh icon. I was trying to load it from `ieframe.dll`, but icons there are 32px, and unfortunately the resizing in Wine produces bad image quality, so no runtime resizing.
Looking at `hhctrl.ocx`, the refresh icon happens to be the right (24px) size, a bit messy (neither `ieframe.dll` or `hhctrl.ocx` expose their `resource.h`), but it could actually work, the question now is, should I be loading external dlls in the first place?