Re: [PATCH v4 0/5] MR4450: winegstreamer: WMA DMO support

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c:
> -
>    return false;
> - }
> -
> - if (IsEqualGUID(&mt->subtype, &MEDIASUBTYPE_MSAUDIO1))
> -
>    format->u.audio_wma.version = 1;
> - else if (IsEqualGUID(&mt->subtype, &MEDIASUBTYPE_WMAUDIO2))
> -
>    format->u.audio_wma.version = 2;
> - else if (IsEqualGUID(&mt->subtype, &MEDIASUBTYPE_WMAUDIO3))
> -
>    format->u.audio_wma.version = 3;
> - else if (IsEqualGUID(&mt->subtype, &MEDIASUBTYPE_WMAUDIO_LOSSLESS))
> -
>    format->u.audio_wma.version = 4;
> - else
> - {
> -
>    ERR("Unexpected subtype %s.\n", debugstr_guid(&mt->subtype));
> -
>    return false;
> - }

We explicitly check this in the caller, so you could even get rid of the else.