22 Mar
2023
22 Mar
'23
8:28 p.m.
On Wed Mar 22 19:20:39 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=130933 Your paranoid android. === debian11 (32 bit report) === shell32: shlexec.c:1362: Test failed: exe three"""quotes next: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe three"""quotes next: arg[1] expected L"three\"quotes" but got L"three\"quotes next" shlexec.c:1362: Test failed: exe four"""" quotes" next 4%3=1: expected 4 arguments, but got 3 shlexec.c:1370: Test failed: exe four"""" quotes" next 4%3=1: arg[1] expected L"four\" quotes" but got L"four\"" shlexec.c:1370: Test failed: exe four"""" quotes" next 4%3=1: arg[2] expected L"next" but got L"quotes next 4%3=1" shlexec.c:1362: Test failed: exe five"""""quotes next: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe five"""""quotes next: arg[1] expected L"five\"quotes" but got L"five\"\"quotes next" shlexec.c:1370: Test failed: exe seven""""""" quotes" next 7%3=1: arg[1] expected L"seven\"\" quotes" but got L"seven\"\"\" quotes" shlexec.c:1370: Test failed: exe twelve""""""""""""quotes next: arg[1] expected L"twelve\"\"\"\"quotes" but got L"twelve\"\"\"\"\"quotes" shlexec.c:1370: Test failed: exe thirteen""""""""""""" quotes" next 13%3=1: arg[1] expected L"thirteen\"\"\"\" quotes" but got L"thirteen\"\"\"\"\"\" quotes" shlexec.c:1362: Test failed: exe "two""quotes next: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe "two""quotes next: arg[1] expected L"two\"quotes" but got L"two\"quotes next" shlexec.c:1362: Test failed: exe "two"" next: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe "two"" next: arg[1] expected L"two\"" but got L"two\" next" shlexec.c:1362: Test failed: exe "three""" quotes" next 4%3=1: expected 4 arguments, but got 3 shlexec.c:1370: Test failed: exe "three""" quotes" next 4%3=1: arg[1] expected L"three\" quotes" but got L"three\"" shlexec.c:1370: Test failed: exe "three""" quotes" next 4%3=1: arg[2] expected L"next" but got L"quotes next 4%3=1" shlexec.c:1362: Test failed: exe "four""""quotes next: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe "four""""quotes next: arg[1] expected L"four\"quotes" but got L"four\"\"quotes next" shlexec.c:1370: Test failed: exe "six"""""" quotes" next 7%3=1: arg[1] expected L"six\"\" quotes" but got L"six\"\"\" quotes" shlexec.c:1370: Test failed: exe "eleven"""""""""""quotes next: arg[1] expected L"eleven\"\"\"\"quotes" but got L"eleven\"\"\"\"\"quotes" shlexec.c:1370: Test failed: exe "twelve"""""""""""" quotes" next 13%3=1: arg[1] expected L"twelve\"\"\"\" quotes" but got L"twelve\"\"\"\"\"\" quotes" shlexec.c:1362: Test failed: exe "the crazy \\"""\\" quotes: expected 3 arguments, but got 2 shlexec.c:1370: Test failed: exe "the crazy \\"""\\" quotes: arg[1] expected L"the crazy \\\"\\" but got L"the crazy \\\"\\ quotes"
So CI is ready and as expected several tests failed. At first glance they look artificial, for instance testing the first on Windows show: ```
python three"""quotes next
python: can't open file 'three"quotes next': [Errno 22] Invalid argument
python -c "from sys import argv; del argv[0]; print(str(len(argv)) + ' | ' + ' | '.join(argv))" three"""quotes next
1 | three"quotes next ``` whereas the test assumes 2 parameters: `three"quotes` and `next` instead of `three"quotes next` (+ 1 for exe-name).
I'll check all failing tests against default windows notation and adjust the tests accordingly.