On Mon Jan 2 16:48:54 2023 +0000, eric pouech wrote:
I had a look... I changed a bit your first patch (about introducing dbg_module in winedbg):
- IMO, we should keep the loaded module list in winedbg in sync with
dbghelp... so don't have two separate functions... nothing critical, mostly stylish The last (TMP) didn't work with my local tests. Moreover:
- current code (before your patches) didn't expect at all the WOW64
situation (32bit debuggee and 64bit debuggeer).
- reduced a bunch of PE format reading by mapping the DLL image and
using Rtl* functions that already implement it.
- So I reworked it.
You can find the two modified patches attached here [patch.tls](/uploads/d2230ff815ddfa90f674439dfbc52b7d/patch.tls). They've been successfully tested with and without the ntdll patch applied (and in the three cases of bitness: 32/32, 64/64 and 64/32). So these two patches should be first in serie, and the ntdll last.
I put the patches in if you want to make sure everything still works