Re: [PATCH v3 0/3] MR3424: msxml3: Add ValidateOnParse property support.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c:
> -
> -
>    i++;
> -
>    if (!is_clsid_supported(entry->guid, &IID_IXMLDOMDocument2))
> -
>    {
> -
>        skip("IXMLDOMDocument2 is not supported by %s.\n", entry->clsid);
> -
>        entry++;
> -
>        continue;
> -
>    }
> -
> -
>    hr = CoCreateInstance(entry->guid, NULL, CLSCTX_INPROC_SERVER, &IID_IXMLDOMDocument2, (void **)&doc);
> -
>    ok(hr == S_OK, "%d: got %#lx.\n", i, hr);
> -
> -
>    V_VT(&var) = VT_I2;
> -
>    V_I2(&var) = 0;
> -
>    hr = IXMLDOMDocument2_getProperty(doc, _bstr_("ValidateOnParse"), &var);
> -
>    ok(hr == entry->hr || broken(hr == E_FAIL) /* win8 */, "%d: got hr %#lx.\n", i, hr);

As I understand this only fails on CLSID_DOMDocument40 running win8? The property is documented as msxml6-only. Please move detection for broken msxml4 on win8 earlier and skip entire loop, instead of having multiple broken() checks.