[PATCH v3 2/2] ntdll: Do not fail NtCreateUserProcess() if requested access doesn't have PROCESS_CREATE_THREAD.

[Paul Gofman]

From: Paul Gofman

---
 dlls/ntdll/tests/thread.c | 4 ++--
 server/thread.c           | 9 ++++++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/dlls/ntdll/tests/thread.c b/dlls/ntdll/tests/thread.c
index 567a94a583d..f7806e0fe62 100644
--- a/dlls/ntdll/tests/thread.c
+++ b/dlls/ntdll/tests/thread.c
@@ -235,9 +235,9 @@ static void test_NtCreateUserProcess(void)
     status = NtCreateUserProcess( &process, &thread, PROCESS_TERMINATE, SYNCHRONIZE,
                                   NULL, NULL, 0, THREAD_CREATE_FLAGS_CREATE_SUSPENDED, params,
                                   &create_info, &ps_attr );
-    todo_wine ok( status == STATUS_SUCCESS, "Got unexpected status %#lx.\n", status );
+    ok( status == STATUS_SUCCESS, "Got unexpected status %#lx.\n", status );
     status = NtTerminateProcess( process, 0 );
-    todo_wine ok( status == STATUS_SUCCESS, "Got unexpected status %#lx.\n", status );
+    ok( status == STATUS_SUCCESS, "Got unexpected status %#lx.\n", status );
     CloseHandle( process );
     CloseHandle( thread );
 }
diff --git a/server/thread.c b/server/thread.c
index 5ad060108e3..8ffe7ffdb33 100644
--- a/server/thread.c
+++ b/server/thread.c
@@ -1520,12 +1520,19 @@ DECL_HANDLER(new_thread)
     const struct object_attributes *objattr = get_req_object_attributes( &sd, &name, NULL );
     int request_fd = thread_get_inflight_fd( current, req->request_fd );

-    if (!(process = get_process_from_handle( req->process, PROCESS_CREATE_THREAD )))
+    if (!(process = get_process_from_handle( req->process, 0 )))
     {
         if (request_fd != -1) close( request_fd );
         return;
     }

+    if (process->running_threads && !(get_handle_access( current->process, req->process ) & PROCESS_CREATE_THREAD))
+    {
+        if (request_fd != -1) close( request_fd );
+        set_error( STATUS_ACCESS_DENIED );
+        goto done;
+    }
+
     if (process != current->process)
     {
         if (request_fd != -1)  /* can't create a request fd in a different process */