Yes, isn’t it better to just name the functions differently or put some info in the message itself? If it is a problem for winrt maybe we’d better introduce a new trace macro with extra context?
Note that if the log is from slightly different version the line numbers won’t match.
I think at very least this should be enabled by special debug channel, making it always there will increase the log size with a noise which is not needed most of the time.
On 24 Feb 2023, at 8:06, Rémi Bernon wine@gitlab.winehq.org wrote:
I think this is useful to distinguish between multiple functions sharing the same name, or between similar messages within the same function. Arguably this could be done by renaming the functions, or making the message more unique, but it'd be easier to just add more context.
With WinRT this is especially true as the same interfaces are implemented for many classes, and functions names are already overly verbose.
The output could be made optional but I'm not sure why it should be. In any case, passing the data to `__wine_dbg_header` will also help anyone with similar local change avoid the huge cost of a `wine/debug.h` diff. The same thing would be true with return address information, but I think it's more debatable whether it is useful outside of debugging.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2274#note_25404