Re: [PATCH 0/1] MR6574: findstr: Support search with regular expressions.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about programs/findstr/main.c:
> -
>    return match_here(str + 1, regexp, pos + 1, case_sensitive);
> - return FALSE;
>
> +}
> -
>
> +static BOOL match_star(WCHAR c, const WCHAR *str, const WCHAR *regexp, UINT pos, BOOL case_sensitive)
> +{
> - do { if (match_here(str, regexp, pos, case_sensitive)) return TRUE; }
> - while (*str && (match_char(*str++, c, case_sensitive) || c == '.'));
> - return FALSE;
>
> +}
> -
>
> +static BOOL match_regexp(const WCHAR *str, const WCHAR *regexp, BOOL case_sensitive)
> +{
> - if (wcsstr(regexp, L"[")) FIXME("character ranges (i.e. [abc], [^a-z]) are not supported\n");
> - if (wcsstr(regexp, L"\<") || wcsstr(regexp, L"\>")) FIXME("word position (i.e. \< and \>) not supported\n");
> -

```suggestion:-0+0
    if (wcsstr(regexp + 1, L"^")) FIXME("metacharacter '^' found after first char\n");
    If (wcscspn(regexp, L"$") + 1 < wcslen(regexp)) FIXME("metacharacter '$' found before last char\n");

```