Paul Gofman (@gofman) commented about dlls/ntdll/tests/sync.c:
- NTSTATUS status;
- DWORD ret;
- for (i = 0; i < 50; i++)
- {
for (j = 0; j < ARRAY_SIZE(tests); j++)
{
const struct delay_param *test = &tests[j];
timeout.QuadPart = test->timeout;
apc_count = 0;
if (test->queue_apc)
{
int k;
for (k = 0; k < 8; k++)
ok( QueueUserAPC( apc_proc, GetCurrentThread(), (ULONG_PTR)&apc_count ),
it is better not to call the tested functions inside ok(). In this case not sure ok() is needed here, it is very unlikely to fail and if it will the test will fail anyway?