Re: [PATCH v18 0/5] MR820: Implement application hives

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about server/registry.c:
> +static int key_close_handle( struct object *obj, struct process *process, obj_handle_t handle )
> +{
> - struct key *key = (struct key *) obj;
> - FILE *file;
> - struct notify *notify = find_notify( key, process, handle );
> - if (notify) do_notification( key, notify, 1 );
> - if (key->filename)
> - {
> -
>    file = fopen( key->filename, "w" );
> -
>    if (file)
> -
>    {
> -
>        save_all_subkeys( key, file );
> -
>        if (fclose( file )) file_set_error();
> -
>    }
> -
>    else
> -
>        file_set_error();

Setting the error in a close notification is not useful.