Re: [PATCH v25 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/wintypes/tests/propertyset.c:
> - hr = RoGetActivationFactory( name, &IID_IActivationFactory, (void **)&factory );
> - ok( hr == S_OK || broken( hr == REGDB_E_CLASSNOTREG ),
> -
>    "RoGetActivationFactory failed, hr %#lx.\n", hr );
> - if (hr == REGDB_E_CLASSNOTREG)
> - {
> -
>    win_skip( "%s runtimeclass not registered, skipping tests.\n",
> -
>              wine_dbgstr_w( class_name ) );
> -
>    WindowsDeleteString( name );
> -
>    RoUninitialize();
> -
>    return;
> - }
> - WindowsDeleteString( name );
> - class_name = RuntimeClass_Windows_Foundation_PropertyValue;
> - hr = WindowsCreateString( class_name, wcslen( class_name ), &name );
> - ok( SUCCEEDED( hr ), "got %#lx\n", hr );
> - hr = RoGetActivationFactory( name, &IID_IPropertyValueStatics, (void **)&statics );

I don't see this IPropertyValueStatics actually used anywhere. This is probably just a leftover from copy-pasting existing tests. Please remove them. Also, this suggests that you should thoroughly review your code before submitting it.