Re: [PATCH v6 0/5] MR767: vkd3d-shader/dxil: Tessellation part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> +static enum vkd3d_shader_sysval_semantic sysval_semantic_from_dxil_semantic_kind(enum dxil_semantic_kind kind,
> -
>    enum vkd3d_tessellator_domain domain)
>
> {
> - if (kind < ARRAY_SIZE(sysval_semantic_table))
> - if (kind == SEMANTIC_KIND_TESSFACTOR)
> - {
> -
>    switch (domain)
> -
>    {
> -
>        case VKD3D_TESSELLATOR_DOMAIN_LINE:
> -
>            return VKD3D_SHADER_SV_TESS_FACTOR_LINEDET;
> -
>        case VKD3D_TESSELLATOR_DOMAIN_TRIANGLE:
> -
>            return VKD3D_SHADER_SV_TESS_FACTOR_TRIEDGE;
> -
>        case VKD3D_TESSELLATOR_DOMAIN_QUAD:
> -
>            return VKD3D_SHADER_SV_TESS_FACTOR_QUADEDGE;
> -
>        default:
> -
>            /* Error is handled during parsing. */

I wouldn't remove the FIXME() here. If anything I'd replace it with something stronger (`vkd3d_unreachable()`), but if for some bad reason we end up here in spite of the validation we did before I'd like to know.