Re: [PATCH v2 0/3] MR6744: dlls/setupapi: Implement SetupDiGetDevicePropertyKeys

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/setupapi/devinst.c:
>                                        DEVPROPKEY *prop_keys, DWORD prop_keys_len,
>                                        DWORD *required_prop_keys, DWORD flags )
>
> {
> - FIXME( "(%p, %p, %p, %ld, %p, %#lx) stub!\n", devinfo, device_data, prop_keys, prop_keys_len,
> - WCHAR props_path[] = L"Properties\";
> - struct device *device;
> - DWORD count = 0, i;
> - HKEY hkey;
> - LSTATUS ls;
> - DEVPROPKEY *keys_buf = NULL;
> -
> - TRACE( "(%p, %p, %p, %ld, %p, %#lx)\n", devinfo, device_data, prop_keys, prop_keys_len,

I'd advocate for using the trace style in e.g. SetupDiInstallDevice() for new code. Also, DWORDs are unsigned and should use %lu.