On Tue Mar 12 17:04:00 2024 +0000, Zebediah Figura wrote:
Maybe move the TRACE_ON() check to hlsl_dump_state_block()?
I did it this way because we also wrap on `if (TRACE_ON())` other similar calls to ``` // on spirv.c if (TRACE_ON()) rb_for_each_entry(&ctx->functions, dump_function, ctx); ``` ``` // on ir.c and hlsl_codegen.c if (TRACE_ON()) rb_for_each_entry(&ctx->functions, dump_function, ctx); ``` Even though all these functions call `vkd3d_string_buffer_trace()` which also does the check.