On Tue Feb 28 21:17:22 2023 +0000, Henri Verbeet wrote:
There are some minor style and formatting issues in this series that I'm going to ignore for the moment. The test either doesn't test the changes in patch 2/2, or it fails before that patch. The larger issue with this series though is that it doesn't seem quite ideal to potentially set and restore the stream source frequency on each DrawPrimitive()/DrawPrimitiveUP() call, because of the resulting state invalidation. It may be time to move the d3d9-style instance count handling out of wined3d and track that entirely in d3d9.
The changes in d3d9\test is clearly covers changes in my patch, it fails if instancing happens for not indexed d3d9 draws, but it is disabled in pipeline now
tools/gitlab/test.yml ``` test-linux-32: extends: .wine-test variables: EXCLUDE_TESTS: "d3d10core:d3d10core d3d11:d3d11 d3d8:device d3d8:visual d3d9:d3d9ex d3d9:device d3d9:visual" ```