Re: [PATCH 0/5] MR3177: wine{alsa,coreaudio,oss,pulse}: Match GetAudioEndpoint implementations.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/wineoss.drv/mmdevdrv.c:
>      RegCloseKey(key);
>
> }
>
> -static const OSSDevice *get_ossdevice_from_guid(const GUID *guid)
> +static BOOL get_device_name_by_guid(const GUID *guid, char *name, const SIZE_T name_size, EDataFlow *flow)
>  {
>      OSSDevice *dev_item;
> - LIST_FOR_EACH_ENTRY(dev_item, &g_devices, OSSDevice, entry)
> -
>    if(IsEqualGUID(guid, &dev_item->guid))
> -
>        return dev_item;
> - return NULL;
> - LIST_FOR_EACH_ENTRY(dev_item, &g_devices, OSSDevice, entry){
> -
>    if(IsEqualGUID(guid, &dev_item->guid)){
> -
>        if(flow)
> -
>            *flow = dev_item->flow;
> -
>        strncpy(name, dev_item->devnode, name_size);

Let's please not use `strncpy()`.