Or to put that more specifically, here's an additional test case (using E_UNEXPECTED, which map_hres does not translate) to add to your patch
```c store_script_error = &error1; SET_EXPECT(OnScriptError); hres = parse_script_ar("throwException &h8000FFFF&"); ok(hres == E_UNEXPECTED, "got error: %08lx\n", hres); CHECK_CALLED(OnScriptError);
memset(&ei, 0xcc, sizeof(ei)); hres = IActiveScriptError_GetExceptionInfo(error1, &ei); ok(hres == S_OK, "GetExceptionInfo returned %08lx\n", hres); ok(!ei.wCode, "wCode = %x\n", ei.wCode); ok(!ei.wReserved, "wReserved = %x\n", ei.wReserved); if(is_english) { ok(!ei.bstrSource, "bstrSource = %s\n", wine_dbgstr_w(ei.bstrSource)); ok(!ei.bstrDescription, "bstrDescription = %s\n", wine_dbgstr_w(ei.bstrDescription)); } ok(!ei.bstrHelpFile, "bstrHelpFile = %s\n", wine_dbgstr_w(ei.bstrHelpFile)); ok(!ei.dwHelpContext, "dwHelpContext = %lx\n", ei.dwHelpContext); ok(!ei.pvReserved, "pvReserved = %p\n", ei.pvReserved); ok(!ei.pfnDeferredFillIn, "pfnDeferredFillIn = %p\n", ei.pfnDeferredFillIn); ok(ei.scode == E_UNEXPECTED, "scode = %lx\n", ei.scode); free_ei(&ei);
IActiveScriptError_Release(error1); ```
https://testbot.winehq.org/JobDetails.pl?Key=123976 has the whole patch, and shows this passed on w1064, but failed on wine:
run.c:2493: Test failed: bstrSource = L"Microsoft VBScript runtime error" run.c:2495: Test failed: bstrDescription = L"Unknown runtime error"
Because the strings got set even though map_hres was a no-op https://gitlab.winehq.org/jacek/wine/-/blob/f1ce7f0962cbc9dac7cc5df420d31f20...
Adding back the `if(HRESULT_FACILITY(hres) == FACILITY_VBS)` should fix that.