Re: [PATCH 0/1] MR903: ddraw: Add FPS tracing in ddraw_surface_update_frontbuffer().

[Zebediah Figura]

On 9/21/22 04:31, Henri Verbeet (@hverbeet) wrote:
> I'm not against this, but note that in the cases where this doesn't already go through wined3d_swapchain_present(), we're not necessarily updating a full "frame" as such. That's particularly true for applications using Blt()/BltFast() to update the front buffer.

I don't know ddraw very well; is there a better heuristic that occurs to 
you?

If it's just a matter of "some applications are going to blit multiple 
sub-rects to the front buffer", I'm inclined to commit this anyway, 
perhaps with an added code comment to that effect, on the grounds that a 
heuristic that works sometimes and fails other times is still better 
than none at all. I welcome disagreement on that though.