On Wed Feb 28 13:24:34 2024 +0000, Alexandros Frantzis wrote:
The purpose of this check is to only fail the build when EGL is missing and both `--with-wayland` and `--with-opengl` are specified. Without this check the build would also fail (due to the following `WINE_NOTICE_WITH`) when EGL is missing and the configure is just `--with-opengl`. In other words I didn't want non-explicit Wayland builds to suddenly require EGL.
I don't think `WINE_NOTICE_WITH` causes a failure, only a message?
I saw after with the later commits why it was done like that, my comments were mostly based on the idea that it would be interesting to use EGL in some win32u common code at some point [^1]. It doesn't matter much anyway.
[^1] On that topic, I'm not much thrilled with the idea of having yet another driver-specific GL implementation, but doing it in win32u will require more experimentation and it's maybe a bit early for that, and I don't want to block this MR just because of that.