Re: [PATCH v4 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/string.c:
> */
>  int __cdecl _stricmp_l(const char *s1, const char *s2, _locale_t locale)
>  {
> +#if _MSVCR_VER>=140
> - return _strnicmp_l(s1, s2, INT_MAX, locale);
>
> +#else
> - /* Old versions of msvcrt.dll didn't have count <= INT_MAX check */
> return _strnicmp_l(s1, s2, -1, locale);
>
> +#endif /* _MSVCR_VER>=140 */

There's no need for ifdef's here, you can always call the function with INT_MAX parameter.