Re: [PATCH 0/3] MR7577: d3dx9: Implement D3DXSaveVolumeToFile{A,W,InMemory}().

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/volume.c:
> -
> -
>    wsprintfA(name_buf_a, "save_volume_a.%s", tests[i].suffix);
> -
>    wsprintfW(name_buf_w, L"save_volume_w.%S", tests[i].suffix);
> -
> -
>    /*
> -
>     * Test twice, first with a box that has a depth of 2, then second
> -
>     * with a box that has a depth of 1.
> -
>     */
> -
>    for (j = 0; j < 2; ++j)
> -
>    {
> -
>        winetest_push_context("%u", j);
> -
>        hr = D3DXFillVolumeTexture(volume_texture, fill_func_volume, NULL);
> -
>        ok(hr == D3D_OK, "Unexpected hr %#lx.\n", hr);
> -
> -
>        set_box(&box, 0, 0, 16, 16, j, 2);
> -
>        hr = D3DXSaveVolumeToFileA(name_buf_a, tests[i].format, volume, NULL, &box);

I think we want to use temporary filenames and paths here (e.g. `GetTempPathA/W` and `GetTempFileNameA/W`). In other words, the idea from asm.c's `create_file()`, not surface.c `create_file()` :sweat_smile: