1 Feb
2023
1 Feb
'23
3:39 p.m.
On Wed Feb 1 15:26:26 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=128994 Your paranoid android. === debian11 (32 bit report) === dxgi: dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 0. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 1. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 2. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 3. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 4. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 10. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 11. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 14. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 18. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 19. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 20. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 21. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 23. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 24. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 25. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 26. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 27. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 33. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 34. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 37. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 41. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 42. dxgi.c:4501: Test succeeded inside todo block: Got usage 146ee8, expected 60, test 43.
I believe this is because of a use-after-free bug that is fixed with the LFH as we avoid touching the blocks now. Currently the `dxgi:dxgi` test crashes silently and only testbot catches that with:
``` The main process has no test summary line The test has unaccounted for failure messages The test has unaccounted for todo messages The test returned success despite having failures ```