Re: [PATCH 0/1] MR7717: Initial patch for converting Wine to Rust

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about tools/wine/wine.rs:
> - } else {
> -
>    "".to_string()
> - }
>
> +}
> -
>
> +fn is_pe_target(_target: &Target) -> bool {
> - // Implement platform-specific PE detection logic if needed
> - false
>
> +}
> -
>
> +fn load_ntdll(bindir_in: Option<String>, libdir_in: Option<String>) -> Library {
> - let arch_dir = get_arch_dir(&get_default_target());
> - let winedllpath = env::var("WINEDLLPATH").unwrap_or_default();
> -
> - unsafe {
> -
>    if let Some(ref bindir) = bindir_in {

Prefer ergonomic patterns whenever possible.

Let's forget the bad ol' days of pointers[^1].

[^1]: Let's also forget the fact that Rust actually, still, has pointers.