On Wed Nov 27 11:50:26 2024 +0000, eric pouech wrote:
well, o well looks like I mislead you. after investigating the Note2 above, it turns out VerifyConsoleIoHandle() isn't working as I expected on native (not to enter all the details, but it doesn't succeed on "modern" unbound console handles). so we should be using GetConsoleMode() instead of VerifyConsoleHandle() to test for a valid console handle also, testing on Win7 is kinda hard (console inheritance evolved a bit since then), and after a couple of unsucessful attempts, I leant to disabling testing for timeout on Win7 this attached patch should let all the tests pass on Windows (https://testbot.winehq.org/JobDetails.pl?Key=150003&f201=exe32.report&am...) [patch.timeout3](/uploads/d685df34d10de949343f15b33597be85/patch.timeout3) it should also let winetest works when run from a unix console there's still a failing test on Wine side, but they should be easy to fix now and since MR!6888 has been merged, you no longer need to take care of returning STATUS_CONTROL_C_EXIT (the default handlers will)
done